jesseduffield / lazygit

simple terminal UI for git commands

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

On mac, runnning lazygit in a tmux popup pane fails

carjuan opened this issue · comments

Describe the bug
On Mac, when using tmux popup pane feature: tmux popup -E "lazygit", I get *exec.ExitError status 1 as seen in screenshot below.
If not running Lazygit in a tmux popup pane, that is in a regular tmux session, it works as expected.

To Reproduce
Steps to reproduce the behavior:

  1. On Mac, run tmux
  2. type command `tmux popup -EE "lazygit"
  3. floating window shows "An error occurred..."

Expected behavior
I have installed lazygit version 0.34 and tmux version 3.3a on both Ubuntu 20.04.4 LTS and WSL. They both run as expected. See Additional context for screenshots of expected behaviour

Screenshots
Screen Shot 2022-06-11 at 3 20 39 PM

Desktop (please complete the following information):

  • OS: Darwin
  • Lazygit Version: 0.34

Additional context
This is what I get when using a Linux machine or WSL which is the expected behaviour:
WbpC5XK

Screenshot 2022-06-12 at 10 21 02 - kitty@2x

strange, it works for me ...

@carjuan have you had any luck narrowing it down, maybe? I can't reproduce it locally, and it seems to work for @tg0h as well.

Trying a different terminal emulator, building current master?

I'm having the same issue! I am running on alacritty, zsh, Intel Mac.

@serhez current master or v0.34? If it's the latter, try the former.

Just tested it on an M1 Pro Mac, and it also fails the same way.

@mark2185 I just brew'd it today, it shouldn't be master right?

I presume it's the latest release (3 months old), not master.

I have tried the brew formula from core, as well as your own, and I get these outputs respectively when running lazygit -v:

commit=, build date=, build source=homebrew, version=0.34, os=darwin, arch=arm64
commit=7be25a105d389a262ef040133a4270f2f745d255, build date=2022-03-17T07:07:02Z, build source=binaryRelease, version=0.34, os=darwin, arch=arm64

None of them work, they yield the same error. I'll try building from source with the current master and come back in a sec.

👆🏻 It works on master (I built from source using go install). Ideally, I'd like to have lazygit through brew so that I don't have to manually build for updates, can this fix be released any time soon?

Thanks btw :)

For that we'll have to summon @jesseduffield .

In other news, does brew support some sort of -git packages like the AUR does? I'm not very experienced with homebrew, but if anyone would like to contribute something that would allow people to install current master, that'd be swell!

I have been holding off on a release for a while but it really is time for one. I'll try to get one out today (will take a while to write up the release notes though given the time since the last release haha)

👆🏻 It works on master (I built from source using go install). Ideally, I'd like to have lazygit through brew so that I don't have to manually build for updates, can this fix be released any time soon?

Thanks btw :)

This!

@serhez current master or v0.34? If it's the latter, try the former.

I built it from source and it now works. Just as @serhez described.

@jesseduffield Were you able to get that new release out, I'm still seeing the issue when installing from Homebrew today.

@lougreenwood not yet, v0.34 is still the latest version. I'll let you know here when it gets updated, in the meantime I'd suggest you to keep using the manually built one.

@lougreenwood v0.35 is out, feel free to take it for a spin!

@mark2185 I can't get it for Apple Silicon on brew yet, I get v0.34 (using arch --arm64 brew install lazygit).

Oh, uh... the brew bot didn't fire up yet, I think. It should happen soon-ish, I believe... let's give it time.

@serhez how about now?

@mark2185 still getting v0.34 😞 I am guessing it's on homebrew's side to update the tap?

can confirm, 0.35 is up, running and working as expected now! Thank you guys @jesseduffield @mark2185

ezoic increase your site revenue