jesseduffield / lazygit

simple terminal UI for git commands

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Keyboard shortcut for 'move patch into new commit' doesn't work

froody opened this issue · comments

Describe the bug
In the patch options menu (pressing in patch mode) there's an entry to 'move patch into new commit', and looking at the source code it seems that pressing 'n' should trigger this, but it doesn't.

{
    Label:   "move patch into new commit",
    OnPress: gui.handlePullPatchIntoNewCommit,
    Key:     'n',
},

To Reproduce
Steps to reproduce the behavior:

  1. Run lazygit
  2. Select "Commits" panel (press twice)
  3. Select a commit (press return/enter)
  4. Select a file (press down; enter)
  5. Select a hunk and press space to create an entry in the custom patch
  6. Open the patch options menu (press
  7. Press 'n'

Expected behavior
The patch is moved to a new commit

Actual behavior
Nothing happens

Screenshots

Screen Shot 2022-05-18 at 9 51 50 am

Desktop (please complete the following information):

  • OS: Mac OS X 12.3.1
  • Lazygit Version: Unknown
  • The last commit id if you built project from sources: f31dcd3

Additional context
Lazygit is running on Ubuntu 20.04/x86_64, so I'm accessing it via SSH

Does it work if you press enter on said option?

Also, it's a bit odd you don't have the mappings in a column left to the options, like in the attached screenshot. Could you give latest master a spin?

image

@froody does the issue still appear on v0.35?

ezoic increase your site revenue