fastlane / fastlane

🚀 The easiest way to automate building and releasing your iOS and Android apps

Home Page:https://fastlane.tools

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Release notes not being correctly uploaded

pennal opened this issue · comments

New Issue Checklist

Issue Description

We are currently experiencing a weird issue when publishing an app to the store. Although our deliver action contains all the required params, App Store Connect is complaining that the release notes (whatsNew) is not set.

This is the current status of our deliver action

deliver(
    platform: "ios",
    app_identifier: bundleId,
    languages: ["it"],
    team_id: teamId,
    team_name: teamName,
    app_version: version,
    run_precheck_before_submit: false,
    force: true,
    ipa: "builds/#{bundleId}/#{xcodeTarget}-app-store.ipa",
    screenshots_path: "screenshots/#{bundleId}",
    skip_metadata: true,
    release_notes: {
      'default': release_notes,
      'it': release_notes
    },
    submission_information: { # Comes from https://github.com/fastlane/fastlane/issues/5542#issuecomment-254201994,
      add_id_info_uses_idfa: false,
      export_compliance_uses_encryption: true,
      export_compliance_is_exempt: true
    },
    submit_for_review: true,
    automatic_release: true
  )

With these settings, we get the following error:

appStoreVersions with id '<REDACTED>' is not in valid state. - This resource cannot be reviewed, please check associated errors to see why.
The provided entity is missing a required attribute - You must provide a value for the attribute 'whatsNew' with this request

I am a bit confused currently. We want the release notes and the screenshots to be uploaded, but NOT the rest of the metadata since this will be handled by non-technical users. But the release notes come from a CMS that developers handle and therefore must be updated with every build uploaded and put into review.

We are running the latest version (Using fastlane 2.206.2), and no other error is detected. I have seen a similar error in #17318

Looking at the documentation, my assumption was that the skip_metadata flag only skips the folder upload, but any field that is explicitly set in the action will be uploaded. Is this correct or is my assumption wrong?

Command executed
bundle exec fastlane store_distribution_lane
Complete output when running fastlane, including the stack trace and command used
 CANNOT UPLOAD THIS INFO DUE TO SENSITIVE INFORMATION

Environment

swift-driver version: 1.45.2

✅ fastlane environment ✅

Stack

Key Value
OS 12.4
Ruby 2.7.2
Bundler? true
Git git version 2.32.1 (Apple Git-133)
Installation Source ~/.rbenv/versions/2.7.2/bin/fastlane
Host macOS 12.4 (21F79)
Ruby Lib Dir ~/.rbenv/versions/2.7.2/lib
OpenSSL Version OpenSSL 1.1.1n 15 Mar 2022
Is contained false
Is homebrew false
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 13.4.1
Swift Version 5.6.1

System Locale

Variable Value
LANG en_US.UTF-8 ✅
LC_ALL en_US.UTF-8 ✅
LANGUAGE

fastlane files:

`./fastlane/Fastfile` Removed, sensitive information included

No Appfile found

fastlane gems

Gem Version Update-Status
fastlane 2.206.2 ✅ Up-To-Date

Loaded fastlane plugins:

Plugin Version Update-Status
fastlane-plugin-send_e_mail 0.1.4 ✅ Up-To-Date
Loaded gems
Gem Version
did_you_mean 1.4.0
bundler 2.3.11
uri 0.10.0
rake 13.0.6
rexml 3.2.5
CFPropertyList 3.0.5
public_suffix 4.0.7
addressable 2.8.0
artifactory 3.0.15
atomos 0.1.3
aws-eventstream 1.2.0
aws-partitions 1.598.0
aws-sigv4 1.5.0
jmespath 1.6.1
aws-sdk-core 3.131.1
aws-sdk-kms 1.57.0
aws-sdk-s3 1.114.0
babosa 1.0.4
claide 1.1.0
colored 1.2
colored2 3.1.2
highline 2.0.3
commander 4.6.0
declarative 0.0.20
digest-crc 0.6.4
unf_ext 0.0.8.2
unf 0.1.4
domain_name 0.5.20190701
dotenv 2.7.6
emoji_regex 3.2.3
excon 0.92.3
faraday-em_http 1.0.0
faraday-em_synchrony 1.0.0
faraday-excon 1.1.0
faraday-httpclient 1.0.1
multipart-post 2.0.0
faraday-multipart 1.0.4
faraday-net_http 1.0.1
faraday-net_http_persistent 1.2.0
faraday-patron 1.0.0
faraday-rack 1.0.0
faraday-retry 1.0.3
ruby2_keywords 0.0.5
faraday 1.10.0
http-cookie 1.0.5
faraday-cookie_jar 0.0.7
faraday_middleware 1.2.0
fastimage 2.2.6
gh_inspector 1.1.3
jwt 2.4.1
memoist 0.16.2
multi_json 1.15.0
os 1.1.4
signet 0.16.1
googleauth 1.1.3
httpclient 2.8.3
mini_mime 1.1.2
trailblazer-option 0.1.2
uber 0.1.0
representable 3.2.0
retriable 3.1.2
webrick 1.7.0
google-apis-core 0.5.0
google-apis-androidpublisher_v3 0.22.0
google-apis-playcustomapp_v1 0.8.0
google-apis-iamcredentials_v1 0.11.0
google-apis-storage_v1 0.15.0
google-cloud-env 1.6.0
google-cloud-errors 1.2.0
google-cloud-core 1.6.0
google-cloud-storage 1.36.2
json 2.6.2
mini_magick 4.11.0
naturally 2.2.1
optparse 0.1.1
plist 3.6.0
rubyzip 2.3.2
security 0.1.3
simctl 1.6.8
terminal-notifier 2.0.0
unicode-display_width 1.8.0
terminal-table 1.8.0
tty-screen 0.8.1
tty-cursor 0.7.1
tty-spinner 0.9.3
word_wrap 1.0.0
nanaimo 0.3.0
xcodeproj 1.21.0
rouge 2.0.7
xcpretty 0.3.0
xcpretty-travis-formatter 1.0.1
fastlane-plugin-send_e_mail 0.1.4

generated on: 2022-06-13

As I suspected, setting the skip_metadata parameter to true skips ALL metadata, even if you explicitly set the release notes. I solved it by removing it, and the notes were correctly uploaded

ezoic increase your site revenue