fastlane-community / fastlane-plugin-appicon

Generate required icon sizes and iconset from a master application icon.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Adaptive icon support?

drewandre opened this issue · comments

Thank you for such a fantastic plugin! Runs great for me on iOS and Android. I was wondering if there were any plans for android adaptive icons? Android SDK 26+ allows for these types of icons. Users can now choose their icon style (circle or square), and the icons generated by this plugin result in a small square icon within a white circle if the user has their icons set as circular (see photo).

screen shot 2018-07-17 at 5 59 56 pm

Nothing planned, however feel free to fork the plugin and submit a PR if you're interested 👍

I would like to take a stab at it. @drewandre @KrauseFx should we add a new option called adaptive_icon? This would be a bool. If set to true, we will generate adaptive icons.

Hi guys, any news on this?
It's the only thing I'm missing to reach complete automation in building a new white-label app for my clients.

@marcoruggine I have a wip branch to implement this. Feel free to complete it if you can.

@RishabhTayal unfortunately it's beyond my capabilities... otherwise I'd be glad to help!

@marcoruggine I will try to work on it if I get some time. Unfortunately I am swamped at the moment.

@RishabhTayal I really appreciate. Thanks!

@RishabhTayal FYI: my hacky branch: josh-m-sharpe@0ebc583 - handles both rounded and foreground images but shells out to convert instead of using MiniMagick.

I'll be using my fork for a bit to see how that works.

I think we're using different logic and convert args. For example... why are you calculating radius by (R-2)/2 (https://github.com/RishabhTayal/fastlane-plugin-appicon/blob/android-rounded-icon/lib/fastlane/plugin/appicon/actions/android_appicon_action.rb#L71-L72) ?

@KrauseFx Could we get one of these merged in or explain what needs to be fixed between these?

edit: I Just ran @josh-m-sharpe's branch it worked great!

Is there any progress on this? Would love this functionality

Sorry to bug, but is there any chance this could get merged? @KrauseFx @neonichu @joshdholtz @adrum? Thanks!

Will try to work on this later on this week!

Thank you @joshdholtz!